Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31220: Migrated codebase to Symfony 5 #2992

Merged
merged 25 commits into from
Mar 18, 2020
Merged

EZP-31220: Migrated codebase to Symfony 5 #2992

merged 25 commits into from
Mar 18, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Mar 16, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31220
Improvement yes
New feature no
Target version master
BC breaks yes
Tests pass yes
Doc needed yes

Doc:

TODO:

  • Drop TMP commits before merging
  • Migrate codebase to Symfonny 5
  • Resolve outstanding Behat issue.
  • Fix new code according to Coding Standards ($ composer fix-cs).

@webhdx webhdx changed the title Migrated codebase to Symfony 5 EZP-31220: Migrated codebase to Symfony 5 Mar 16, 2020
@webhdx webhdx marked this pull request as ready for review March 16, 2020 15:02
@emodric
Copy link
Contributor

emodric commented Mar 16, 2020

Why will you not support Symfony 4.4 LTS?

I realize Symfony 5 is the latest and greatest, but this means that eZ will not have a LTS release of Symfony for another two years which is not ideal.

@lserwatka
Copy link
Member

We will have LTS sooner. That is why. More info will follow.

@emodric
Copy link
Contributor

emodric commented Mar 16, 2020 •
edited
Loading

I'm talking about Symfony LTS, not eZ. Symfony LTS will be only 5.4 which is due in November 2021.

@gggeek
Copy link
Contributor

gggeek commented Mar 16, 2020

Otoh Sf 4.4 will be supported until 3rd Q 2023...
What are the planned release date and maintenance window for eZPl 3?

alongosz
alongosz requested changes Mar 16, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly CS. What I'm worried about are code examples that were erroneously automatically aligned. Even if you go back to the previous version of fixer (was like that on purpose), it will probably stay like that, unless addressed.

But what's important is that we don't forget to drop dev branches from composer

composer.json Outdated Show resolved Hide resolved
eZ/Bundle/EzPublishCoreBundle/Command/CleanupVersionsCommand.php Show resolved Hide resolved
eZ/Bundle/EzPublishCoreBundle/Features/Context/ConsoleContext.php Show resolved Hide resolved
eZ/Bundle/EzPublishCoreBundle/Features/Context/ConsoleContext.php Show resolved Hide resolved
eZ/Bundle/EzPublishCoreBundle/Resources/config/templating.yml Show resolved Hide resolved
eZ/Publish/Core/Persistence/Legacy/Notification/Gateway.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Search/Legacy/Content/FullTextData.php Outdated Show resolved Hide resolved
eZ/Publish/SPI/FieldType/Tests/FieldTypeTest.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Search/Legacy/Content/Common/Gateway/SortClauseHandler/AbstractRandom.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/Mapper/ContentDomainMapper.php Outdated Show resolved Hide resolved
@webhdx webhdx force-pushed the symfony5 branch 2 times, most recently from 1059d04 to 0e4a7d4 Compare March 17, 2020 09:19
@webhdx webhdx force-pushed the symfony5 branch 2 times, most recently from b7f1863 to 0f0f4ae Compare March 18, 2020 18:07
webhdx and others added 12 commits March 18, 2020 20:58
@webhdx
Fixed behat contexts
5863532
@webhdx
Changed localizeddate to format_(date|time|datetime)
cf44153
@alongosz @webhdx
[CS] Updated .php_cs config for php-cs-fixer ^2.16
b430d22
@alongosz @webhdx
[CS] Aligned code style
3beddc5
@alongosz @webhdx
Reverted unnecessary changes
6eea827
@webhdx
Removed obsolete @injectService syntax
bd2c008
@webhdx
Fixed units tests by adding missing kernel.environment parameter
efa3b4b
@alongosz @webhdx
Bumped memory limit used by Behat process inside docker
eb68f5e
@alongosz @webhdx
[Behat] Changed Symfony cache to be cleared only in prod to save memory
49fc199 
Reason: In behat, test, and dev environments cache is invalidated
on the fly. Clearing it in those cases produces additional unnecessary
overhead and consumes Behat process memory.
@ViniTou @webhdx
EZP-31487: Used Process::fromShellCommandline to build properly escap…
8d3b660 
…ed shell command (#2994)
@adamwojs @webhdx
Fixed path(location) in Twig templates
3040fd3
@webhdx
Prepared composer.json for release
591347e
@webhdx webhdx merged commit f0fa26c into master Mar 18, 2020
@webhdx webhdx deleted the symfony5 branch March 19, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs left review comments

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
Feature Rebase required
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@webhdx @emodric @lserwatka @gggeek @adamwojs @alongosz @ViniTou