Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31457: Fix supportsClass in user provider #2993

Merged
merged 1 commit into from
Mar 23, 2020
Merged

EZP-31457: Fix supportsClass in user provider #2993

merged 1 commit into from
Mar 23, 2020

Conversation

wizhippo
Copy link
Contributor

@wizhippo wizhippo commented Mar 16, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31457
Bug yes
New feature no
Target version 7.x,master
BC breaks no
Tests pass yes/no
Doc needed no

Issue introduced by recent changes in Symfony:

symfony/symfony@fb0be81#diff-3f33c4b578f7ceb90dae8836c3c9a9a7R178

https://github.com/symfony/symfony/blob/fb0be81b7a26f96f65bed5d774771bba026a78fd/src/Symfony/Component/Security/Http/Firewall/ContextListener.php#L178

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@wizhippo wizhippo changed the base branch from master to 7.5 March 17, 2020 17:02
@wizhippo wizhippo changed the base branch from 7.5 to master March 17, 2020 17:03
@adamwojs adamwojs changed the title [EZP-31457] Fix supportsClass in user provider EZP-31457: Fix supportsClass in user provider Mar 21, 2020
@adamwojs
Copy link
Member

@wizhippo Thank you for taking care of this! It's a bug so could you please change target to 7.5? Thank you in advance!

@wizhippo wizhippo changed the base branch from master to 7.5 March 21, 2020 15:23
@adamwojs adamwojs added the Bug label Mar 21, 2020
@micszo micszo self-assigned this Mar 23, 2020
micszo
micszo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE 2.5 with diff.

@micszo micszo removed their assignment Mar 23, 2020
@lserwatka lserwatka merged commit aa9e128 into ezsystems:7.5 Mar 23, 2020
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@wizhippo wizhippo deleted the patch-2 branch March 23, 2020 17:13
alongosz added a commit that referenced this pull request Mar 24, 2020
@alongosz
EZP-31457: Fixed supportsClass of BaseProvider
6ae81ac 
Follow-up to #2993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@michal-myszka michal-myszka Awaiting requested review from michal-myszka

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wizhippo @adamwojs @lserwatka @alongosz @micszo