EZP-31592: Added missing deprecation info to data/mysql/schema.sql #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
requested review from
adamwojs,
mikadamczyk,
Nattfarinn,
webhdx,
ViniTou,
michal-myszka and
a team
ViniTou
approved these changes
Apr 21, 2020
lserwatka
approved these changes
Apr 21, 2020
adamwojs
approved these changes
Apr 21, 2020
gggeek
reviewed
Apr 21, 2020
DominikaK
approved these changes
Apr 21, 2020
2 tasks
bogusez
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5When introducing PostgreSQL support via #2552 I've replaced usage of
data/mysql/schema.sqlwith genericeZ/Bundle/EzPublishCoreBundle/Resources/config/storage/legacy/schema.yaml.The intention was to deprecate
schema.sqlbecause it was possible 3rd party packages or project relied on it directly or at least onCleanInstallerconsuming it. I've forgotten to do it, which I've fixed in this PR.Please note that I'm not deprecating anything in the next 2.5.x, just adding a missing statement about the fact it's deprecated since eZ Platform 2.5.0.
I've tried to make this warning appear on console, but while it's possible, with hack-ish
SELECT, it breaksCleanInstaller. MySQL, compared to other engines, is quite poor unfortunately.QA
Sanity on SQL script execution
Common branch for #3024 and #3025: ezp-31592-31586-schema-sql-combo-for-qa
TODO: