Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30925: Added Language limitation to 'content remove' policy #3036

Merged
merged 5 commits into from
May 27, 2020
Merged

EZP-30925: Added Language limitation to 'content remove' policy #3036

merged 5 commits into from
May 27, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented May 19, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-30925
Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed yes

content remove policy will now accept LanguageLimitation in order to prevent removing Content translation which the user doesn't have access to.

Related PR: ezsystems/ezplatform-admin-ui#1383

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 self-assigned this May 19, 2020
@barw4 barw4 mentioned this pull request May 19, 2020
Merged
2 tasks
@barw4 barw4 requested a review from mikadamczyk May 25, 2020 11:10
Nattfarinn
Nattfarinn approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@Nattfarinn Nattfarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @alongosz . What about versionremove? Isn't it something that should benefit from language limitation as well?

@alongosz
Copy link
Member

Ping @alongosz . What about versionremove? Isn't it something that should benefit from language limitation as well?

@Nattfarinn probably yes, but out of scope here (delete translation feature does not check that). Something @barw4 can consider if he's gonna have time :)

@barw4
Copy link
Member Author

barw4 commented May 26, 2020 •
edited
Loading

@Nattfarinn probably yes, but out of scope here (delete translation feature does not check that). Something @barw4 can consider if he's gonna have time :)

@alongosz sure, I could do that. So the only use case with "versionremove" policy would be an option to delete version within the allowed languages from "Archived versions", right?

@tomaszszopinski tomaszszopinski self-assigned this May 27, 2020
tomaszszopinski
tomaszszopinski approved these changes May 27, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 with diff & eZPlatform 2.5 with patch.

@lserwatka lserwatka merged commit 79049c7 into 7.5 May 27, 2020
@lserwatka lserwatka deleted the EZP-30925 branch May 27, 2020 13:59
@lserwatka
Copy link
Member

You can merge it up

@barw4
Copy link
Member Author

barw4 commented May 27, 2020

Merged: ezsystems/ezplatform-kernel@a5136f7

@DominikaK DominikaK mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@michal-myszka michal-myszka michal-myszka approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @alongosz @lserwatka @mikadamczyk @Nattfarinn @ViniTou @konradoboza @michal-myszka @tomaszszopinski