Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31891: Use specified templates for embedded image and asset FT #3068

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 16, 2020

Question Answer
JIRA issue EZP-31891
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

Introduced by:
ezsystems/ezplatform-admin-ui#1457

As those views are configurable by semantic/parameters this seems to be safe solution in terms of possible overrides.
TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@micszo micszo self-assigned this Oct 20, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.14, v3.1.3 & 3.2-dev with diff.

@micszo micszo removed their assignment Oct 20, 2020
@lserwatka lserwatka merged commit de25988 into 7.5 Oct 20, 2020
@lserwatka lserwatka deleted the ezp-31891-image_rich_text branch October 20, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants