EZP-29246: Avoid double decoding of URL #1360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eZSYS::requestURI is already decoding the URL. The eZURI class does it a 2nd time.
Example of the problem. Given URL:
http://<sitedomain>/(foo)/bar%2Bbar
Double decoded version is is /(foo)/bar bar (that's a space in between)
But the correct value is /(foo)/bar+bar
You can test this by adding following into your pagelayout.tpl:
{$view_parameters|dump()}
Use following URL and look at the dump output:
http://<sitedomain>/(foo)/bar%2Bbar
The correct value is " /(foo)/bar+bar" - the pull request should produce the correct output.
pkamps
changed the title
|
@pkamps, FYI: I tested your pull request and it didn't solve the issue of showing customer information with urls like https://your-server/admin/shop/customerorderview/10/test%2Btest@test.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eZSYS::requestURI is already decoding the URL. The eZURI class does it a 2nd time.
Example of the problem. Given URL:
http://sitedomain/(foo)/bar%2Bbar
Double decoded version is is /(foo)/bar bar (that's a space in between)
But the correct value is /(foo)/bar+bar
You can test this by adding following into your pagelayout.tpl:
{$view_parameters|dump()}
Use following URL and look at the dump output:
http://sitedomain/(foo)/bar%2Bbar
The correct value is " /(foo)/bar+bar" - the pull request should produce the correct output.