Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed fatal error in eZUserType::objectAttributeContent #1396

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pbek
Copy link
Contributor

@pbek pbek commented Oct 24, 2018

Fixed a fatal error in eZUserType::objectAttributeContent because user object could not be loaded

Copy link
Collaborator

@emodric emodric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening curly brace needs to go on own line, but otherwise 👍

@pbek
Copy link
Contributor Author

pbek commented Oct 24, 2018

Opening curly brace needs to go on own line

done

@andrerom andrerom requested a review from glye October 29, 2018 09:26
@glye
Copy link
Member

glye commented Oct 29, 2018

Unrelated to the fix, but isn't it odd that hasObjectAttributeContent() will return false if the user exists but is disabled?

@andrerom
Copy link
Contributor

@pbek Seems there is a conflict here now after #1417, is this still needed?

@pbek
Copy link
Contributor Author

pbek commented Mar 11, 2019

I can't see this anywhere fixed in #1417, so I guess this is still needed.

@andrerom andrerom added this to the 2019.03 milestone Mar 21, 2019
@andrerom
Copy link
Contributor

andrerom commented Apr 2, 2019

ok, would you be able to rebase @pbek ?

@andrerom
Copy link
Contributor

@pbek Is the update her ok with you? And is there a JIRA issue for this?

@pbek
Copy link
Contributor Author

pbek commented Apr 30, 2019

Looks ok to me.

And is there a JIRA issue for this?

Not that I know of.

@andrerom
Copy link
Contributor

@pbek ok, can you add one with info on when you encountered this so we have it for anyone looking up similar case?

@andrerom andrerom removed this from the 2019.03 milestone May 14, 2019
@andrerom
Copy link
Contributor

Dropping from 2019.03 milstone until it is clear what this actually fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants