Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an eZOrder should also remove its eZOrderItems #1460

Open
wants to merge 1 commit into
base: 2019.03
Choose a base branch
from
Open

Removing an eZOrder should also remove its eZOrderItems #1460

wants to merge 1 commit into from

Conversation

gabrielfin
Copy link
Contributor

No description provided.

andrerom
andrerom reviewed Aug 31, 2020
View reviewed changes
kernel/classes/ezorder.php
@@ -1353,6 +1353,7 @@ static function cleanupOrder( $orderID )
$db = eZDB::instance();
$db->begin();
$db->query( "DELETE FROM ezorder where id='$orderID'" );
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderID" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at line below, should this have been:

Suggested change
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderID" );
$db->query( "DELETE FROM ezorder_item WHERE order_id=$orderNr" );

??

@gabrielfin
Copy link
Contributor Author

I don't know why ezorder_status_history uses orderNr instead of orderID, (very confusing btw, since the column and attribute is called order_id) but as far as I can tell, order_item does use orderID. Take a look here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
Community Review wanted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielfin @andrerom