Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8357: Fixed item export #115

Merged
merged 3 commits into from
Jun 6, 2024
Merged

IBX-8357: Fixed item export #115

merged 3 commits into from
Jun 6, 2024

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Jun 4, 2024

Question Answer
JIRA issue IBX-8357
Type bug
Target Ibexa DXP version v3.3.38
BC breaks no
Doc needed no

See IBX-8357.
Issue is only on 3.3.

For QA:
Error can be reproduced with fictional settings for:

PERSONALIZATION_CUSTOMER_ID={...}
PERSONALIZATION_LICENSE_KEY={...}
PERSONALIZATION_HOST_URI=https://{...}

Then - after fix - initial error is gone and 'expected error' is shown :

In EzRecommendationClient.php line 161:
  Client error: `POST https://....` resulted in a `401 Unauthorized` response:

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@reithor reithor marked this pull request as ready for review June 4, 2024 14:44
@reithor reithor requested review from GrabowskiM and a team June 4, 2024 14:48
phpstan-baseline.neon Outdated Show resolved Hide resolved
@reithor reithor force-pushed the ibx-8357-fixed-export-error branch from 4092f93 to bee1b71 Compare June 5, 2024 08:26
@reithor reithor requested a review from ciastektk June 5, 2024 08:29
@ciastektk ciastektk requested a review from a team June 5, 2024 08:42
@konradoboza konradoboza requested a review from a team June 5, 2024 10:12
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 experience.

@ciastektk ciastektk merged commit 9637aed into 2.1 Jun 6, 2024
9 checks passed
@ciastektk ciastektk deleted the ibx-8357-fixed-export-error branch June 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants