IBX-929: Removed unused DeleteLocationEvent

[mateuszdebinski]

Question	Answer
JIRA issue	IBX-929
Type	bug
Target Ibexa DXP version	v3.3
BC breaks	no
Doc needed	no

This event was moved from eZ Platform 2.5 but was under review it turned out that in 2.5 nothing was happening anyway when calling it:
a function that is assigned to a slot in 2.5:

ezrecommendation-client/src/lib/Service/SignalSlotService.php

Line 99 in 7b4ad6f

public function deleteContent(int $contentId): void

where the function getContent return null because content not found:

ezrecommendation-client/src/lib/Service/SignalSlotService.php

Line 186 in 7b4ad6f

private function getContent(int $contentId, ?array $languages = null, ?int $versionNo = null): ?Content

finally, the processSending function does nothing because $content is set to null:

ezrecommendation-client/src/lib/Service/SignalSlotService.php

Line 234 in 7b4ad6f

private function processSending(string $method, string $action, ?Content $content, ?int $versionNo = null): void

After talking to Tomasz, we agreed that this event can be removed in 3.3

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/php-dev-team).

[adamwojs]

Could you please fix issues reported by phpstan ?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[mateuszdebinski]

Could you please fix issues reported by phpstan ?

I corrected this test, but it was not related to my changes, but I think that it will not be a problem to implement these changes along with this PR

[alongosz]

@mateuszdebinski the change is ok, but how does this fix the reported issue?

[mateuszdebinski]

@mateuszdebinski the change is ok, but how does this fix the reported issue?

onDeleteLocation function called updateLocationWithChildren and this function get the location by id and content for the location, which raised exceptions because the location did not exist anymore

[lserwatka]

You can merge it up now.