Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-26608 adding translation for "Metadata" #124

Merged
merged 1 commit into from
May 18, 2017
Merged

EZP-26608 adding translation for "Metadata" #124

merged 1 commit into from
May 18, 2017

Conversation

tomaszmadeyski
Copy link
Contributor

This a follow up on ezsystems/ezpublish-kernel#1988

Adding translation for "Metadata" which was a missing item on default Field Group list

Related Jira issue: https://jira.ez.no/browse/EZP-26608

Copy link
Member

@bdunogier bdunogier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a bugfix ? If yes, we may wanna merge it to 1.5 (the version that shipped with eZ Platform 1.7 LTS).

That aside, I'm good with the change.

@tomaszmadeyski tomaszmadeyski changed the base branch from master to 1.5 May 17, 2017 09:09
@ezrobot
Copy link

ezrobot commented May 17, 2017

Tool version : PHP CS Fixer 2.1.2 by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run --diff -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

                                                           
  [Symfony\Component\Debug\Exception\FatalThrowableError]  
  Class 'Symfony\CS\Config\Config' not found               
                                                           

Exception trace:
 () at /jenkins/jenkins.std/jobs/RepositoryForms-Pull-Request-checker/workspace/.php_cs:3
 include() at /jenkins/jenkins.std/.composer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:213
 PhpCsFixer\Console\ConfigurationResolver->getConfig() at /jenkins/jenkins.std/.composer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:539
 PhpCsFixer\Console\ConfigurationResolver->getFormat() at /jenkins/jenkins.std/.composer/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php:389
 PhpCsFixer\Console\ConfigurationResolver->getReporter() at /jenkins/jenkins.std/.composer/vendor/friendsofphp/php-cs-fixer/src/Console/Command/FixCommand.php:140
 PhpCsFixer\Console\Command\FixCommand->execute() at /jenkins/jenkins.std/.composer/vendor/symfony/console/Command/Command.php:265
 Symfony\Component\Console\Command\Command->run() at /jenkins/jenkins.std/.composer/vendor/symfony/console/Application.php:826
 Symfony\Component\Console\Application->doRunCommand() at /jenkins/jenkins.std/.composer/vendor/symfony/console/Application.php:189
 Symfony\Component\Console\Application->doRun() at /jenkins/jenkins.std/.composer/vendor/symfony/console/Application.php:120
 Symfony\Component\Console\Application->run() at /jenkins/jenkins.std/.composer/vendor/friendsofphp/php-cs-fixer/php-cs-fixer:55

fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--] [<path>]...

@tomaszmadeyski
Copy link
Contributor Author

@bdunogier I rebased it to branch 1.5. Errors which are here reported by phpcsfixer are because of wrong cs-fixer configuration and it will be fixed after #121 merge

@andrerom andrerom merged commit 0958db3 into ezsystems:1.5 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants