Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27659 Subtree and Node policy limitations can't be viewed #136

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

glye
Copy link
Member

@glye glye commented Jul 21, 2017

Fix https://jira.ez.no/browse/EZP-27659
QA

Existing node/subtree limitations are not displayed when editing a policy. This ensures they are visible.

Fixes:

  • Subtreelimitation saves paths (legacy), UDW wants location IDs. Add conversion in the transformer.
  • The form (hidden input text line) needs the IDs comma separated, so that's what the value is, but we have to split them in the template to render their names
  • The IDs are locations not content, so render them correctly as locations
  • Preselect node/subtree limitations in UDW Skipped, as that is a separate issue

@glye glye force-pushed the ezp27659_policy_limitations_invisible_overwritten branch from 1fccb3b to c07ba92 Compare July 21, 2017 09:05
@ezsystems ezsystems deleted a comment from ezrobot Jul 21, 2017
@glye
Copy link
Member Author

glye commented Jul 21, 2017

Preselect node/subtree limitations in UDW

@dpobel Does V1 UDW support this at all? I mean not a browsing start location, but that certain items are already in the "Confirmed items" list when UDW opens.

If it can't do this, we'd either need to add delete buttons for items in the selected item list in policy edit, or skip it alltogether and just accept that whatever you select in UDW overwrites what you had before. (Perhaps suboptimal, but will be replaced in V2 anyway)

UPDATE: Skipped, as it is a separate issue.

@glye glye changed the title [WIP] EZP-27659 Subtree and Node policy limitations can't be viewed, may be overwritten EZP-27659 Subtree and Node policy limitations can't be viewed Jul 27, 2017
@glye glye requested review from bdunogier and andrerom July 27, 2017 14:36
@glye
Copy link
Member Author

glye commented Jul 28, 2017

Thanks, sent to QA.

@glye glye merged commit 691aba5 into 1.5 Jul 28, 2017
@glye glye deleted the ezp27659_policy_limitations_invisible_overwritten branch July 28, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants