Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27631: Implement editing support for Author FieldType #150

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Aug 29, 2017

JIRA: https://jira.ez.no/browse/EZP-27631
!! Please do not merge until #140 is merged. I have to rebase on master and skip duplicated commit first !!

Description

This PR provides basic editing support for:

Please note it isn't prepared for Content translation yet. It also requires JS enrichment done in Hybrid UI.

Copy link
Contributor

@dpobel dpobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the potentially required hidden input, looks good to me

HiddenType::class,
[
'label' => 'content.field_type.ezauthor.id',
'required' => $options['required'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking a hidden input as required is a bit weird

@lserwatka lserwatka merged commit d4e2f2c into ezsystems:master Sep 19, 2017
@webhdx webhdx deleted the EZP-27631_author branch September 27, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants