EZP-27539: Translation support in content edit #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
requested review from
lserwatka,
bdunogier,
mikadamczyk and
Nattfarinn
webhdx
force-pushed
the
translation_support
branch
2 times, most recently
from
e748e24 to
6276945
Compare
bdunogier
approved these changes
Dec 4, 2017
| @@ -103,7 +103,7 @@ public function createWithoutDraftAction($contentTypeIdentifier, $language, $par | |||
|
|
|||
| return new ContentCreateView(null, [ | |||
| 'form' => $form->createView(), | |||
| 'languageCode' => $language, | |||
There was a problem hiding this comment.
It might not be critical, but maybe I'd try to keep some BC here: add language, and comment languageCode as deprecated ?
There was a problem hiding this comment.
I'm not sure. 2.0 will change a lot actually, I'd love to make it as clean as possible in 2.0 so that we aren't left with a lot of deprecations till 3.0. I believe it's just a matter of writing a descriptive doc on what is not backwards compatible.
| @@ -153,7 +156,12 @@ public function processCreateDraft(FormActionEvent $event) | |||
| */ | |||
| private function saveDraft(ContentStruct $data, $languageCode) | |||
| { | |||
| $mainLanuageCode = $this->resolveMainLanguageCode($data); | |||
There was a problem hiding this comment.
Argh, happens to me on word language constantly ;)
| */ | ||
| private function resolveMainLanguageCode($data): string | ||
| { | ||
| return $data->isNew() |
There was a problem hiding this comment.
Should we be a tiny bit protective and test the type of $data, since we don't have typehinting here ?
webhdx
force-pushed
the
translation_support
branch
2 times, most recently
from
5ea6a2a to
673bcbd
Compare
webhdx
force-pushed
the
translation_support
branch
from
673bcbd to
62e2800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Translation support was never implemented in repository-forms. Now there is a need for that in new AdminUI. This PR makes fieldtypes "language" aware which is helpful for developers theming content edit page. It also fixes the issue of nontranslated labels of fieldtypes as this feature is there but never implemented in Admin UI or Platform UI.