EZP-28443: There is no validation for Address in map location #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Dec 14, 2017
There was a problem hiding this comment.
+1
Sees to be unit tests failures caused by other 2.0 changes btw:
EzSystems\RepositoryForms\Tests\FieldType\Mapper\FormTypeBasedFieldValueFormMapperTest::testMapFieldValueFormNoLanguageCode
Undefined index:
EzSystems\RepositoryForms\Tests\FieldType\Mapper\FormTypeBasedFieldValueFormMapperTest::testMapFieldValueFormWithLanguageCode
Undefined index:
EzSystems\RepositoryForms\Tests\FieldType\Mapper\UserAccountFieldValueFormMapperTest::testMapFieldValueFormNoLanguageCode
Error: Call to a member function getRoot() on null
EzSystems\RepositoryForms\Tests\FieldType\Mapper\UserAccountFieldValueFormMapperTest::testMapFieldValueFormWithLanguageCode
Error: Call to a member function getRoot() on null
ref: https://travis-ci.org/ezsystems/repository-forms/jobs/315777822
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address field should always be optional as ezgmaplocation only cares about latitude and longitude.