EZP-29979: As a developer I would like to use getLocation method on ContentCreateSuccessView and ContentEditSuccessView

[kmadejski]

JIRA: https://jira.ez.no/browse/EZP-29979

[mnocon]

Sadly, it breaks when trying to publish a previously saved draft.
I've used dev env with debug enabled.

Steps:

1. Login as admin
2. Go to Content
3. Start creating a Folder (enter "TestName" as name)
4. Save draft
5. Publish

It fails with:

Type error: Argument 1 passed to EzSystems\RepositoryForms\Content\View\ContentEditSuccessView::setLocation() must be an instance of eZ\Publish\API\Repository\Values\Content\Location, null given, called in /home/vagrant/ee_demo/vendor/ezsystems/repository-forms/lib/Content/View/Builder/ContentEditViewBuilder.php on line 126

I believe we shouldn't set the location to null there - it should be the location that was created when publish action was executed? (If it's possible).

[kmadejski]

@andrerom / @ViniTou I have to allow passing null as $location due to the issue found by QA.

@mnocon could you please retest?

[kmadejski]

@mnocon do you see any chance to give it another round of testing? 🙂

[mnocon]

@kmadejski there is a chance 😉 But you're probably aware that 60% of our QA team is on sick leave and it complicates things a bit

[mnocon]

I know that the ticket mentions ContentCreateSuccessView and ContentEditSuccessView only (and it works correctly for them), but wouldn't it make sense to implement LocationValueView also for EzSystems\EzPlatformPageBuilder\View\PageView, EzSystems\EzPlatformFormBuilder\View\FieldConfigurationView and EzSystems\RepositoryForms\User\View\UserUpdateView?

This way we would provide unified experience for developers across all these editing views.

Also, ping @DominikaK - not sure if it's something that is doc-worthy.

[kmadejski]

Good question @mnocon, honestly, I don't know. @ViniTou / @webhdx / @Nattfarinn / @andrerom
WDYT?

[mnocon]

Discussed with Kamil - the rest of the Views can be changed in a follow-up ticket (if decided so).