EZP-29140: User bundle #278
Conversation
ViniTou
force-pushed
the
EZP-29140-user-bundle
branch
from
a9aa8da to
7a4105d
Compare
|
|
||
| class UserRegisterController extends Controller | ||
| /** | ||
| * @deprecated Deprecated in 1.5 and will be removed in 2.0. Please use \EzSystems\EzPlatformUserBundle\Controller\UserRegisterController instead. |
There was a problem hiding this comment.
I think the version is wrong here. It should be 2.5 and 3.0
There was a problem hiding this comment.
Yup, it is 1.5 and 2.0 for adminUI, my bad.
bundle/Resources/config/services.yml
Outdated
| - "@ezrepoforms.user_register.registration_group_loader.configurable" | ||
| calls: | ||
| - [setParam, ["language", "@=service('ezpublish.config.resolver').getParameter('languages', null, null)[0]"]] | ||
| alias: EzSystems\EzPlatformUser\Form\DataMapper\UserRegisterMapper |
There was a problem hiding this comment.
Add deprecated property here and in other services.
| */ | ||
| class UserRegisterMapper | ||
| class UserRegisterMapper extends BaseUserRegisterMapper |
There was a problem hiding this comment.
By using inheritance this class will be prone to accidental BC breaks if something changes in parent class. I'd rather go for composition here to protect interface of this class.
ViniTou
force-pushed
the
EZP-29140-user-bundle
branch
from
1a1e4e1 to
3392d6e
Compare
| * | ||
| * @throws \Exception if the current user isn't allowed to register an account | ||
| * @return \EzSystems\EzPlatformUser\View\Register\FormView|\Symfony\Component\HttpFoundation\Response|null |
There was a problem hiding this comment.
nitpick: @throws \Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException
| * Implementations will call load() with a repository callback as an argument. | ||
| * The repository can be accessed using getRepository(). | ||
| * | ||
| * ** Use with care**. |
There was a problem hiding this comment.
because this is important, maybe it is worth to put it to the top
| /** | ||
| * @var array | ||
| */ | ||
| private $params = []; |
There was a problem hiding this comment.
| private $params = []; | |
| private $params; |
should it be null or array?
| */ | ||
| private $params = []; | ||
|
|
||
| public function __construct(Repository $repository, $params = null) |
There was a problem hiding this comment.
nitpick: missing docblocks
| abstract class ConfigurableSudoRepositoryLoader | ||
| { | ||
| /** | ||
| * @var Repository |
| */ | ||
| private $params = []; | ||
|
|
||
| public function __construct(Repository $repository, $params = null) |
Move and deprecate things based on
ezsystems/ezplatform-user#1