Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30985: Removed deprecated choices_as_values Symfony form option #321

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Oct 4, 2019

Question Answer
JIRA issue EZP-30985
Target version eZ Platform 2.5.x

The choices_as_values Symfony form option has been deprecated since Symfony 3.1.

Ref: https://symfony.com/doc/3.4/reference/forms/types/choice.html#choices-as-values

QA

  • Sanity checks in AdminUI for the following Field Types:

    • Author,
    • Country,
    • Date,
    • DateTime,
    • Media (Image, BinaryFile).
  • Sanity check for creating Content Type with randomly choosen Field Types.

    • Adding Field Type,
    • Updating Field Type,
    • Choosing sort Field Type,
    • Choosing sort order,
    • Setting Field Group,
    • Country FT: default values,
    • Selection FT: default values,
    • Roles: adding/updating of policies,
    • Policies: Limitations chosen from a list (Language, ContentType, etc.)
    • Link manager: status filtering.

@alongosz alongosz changed the title Remove deprecated choices_as_values Symfony form options EZP-30985: Removed deprecated choices_as_values Symfony form option Oct 7, 2019
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webhdx @ViniTou @mikadamczyk @Nattfarinn since this applies to v2.5.x, please let me know if you think we need extra QA here (according to the Sf doc this change should have no effect, so I'm leaning towards merging this).

@alongosz alongosz merged commit 52578bf into ezsystems:2.5 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants