EZP-28900: Removed view transformer from FloatFieldType #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
adamwojs
changed the title
adamwojs
approved these changes
Nov 4, 2019
ViniTou
approved these changes
Nov 5, 2019
|
Now, float is shown in edit mode but there is a difference between displaying decimal separators. In preview is |
|
@katarzynazawada I've fixed it under the same ticket but it required changes in AdminUI: ezsystems/ezplatform-admin-ui#1165 |
|
👍 for fix proposed by @webhdx |
katarzynazawada
approved these changes
Dec 20, 2019
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://jira.ez.no/browse/EZP-28900
The root of the issue is that our
FloatFieldTypeuses view transformer :NumberToLocalizedStringTransformer. This transformer is not set explicitly but it is inherited from symfony'sNumberType. Symfony NumberType needs this transformer because defaultform_fields.html.twiguse<input type='text">to displaynumber_widget. AdminUI overwrites symfony'sform_fields.html.twigincludingnumber_widgetand number are displayed as<input type="number". So this transformer is no needed and causes problems described in the ticket.related to : ezsystems/ezpublish-kernel#2849