fix: Support for locales using decimal separators other than . (dot) #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cracksalad
changed the title
|
Can we use |
You are totally right. |
ezyang
approved these changes
Apr 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
# [4.17.0](v4.16.0...v4.17.0) (2023-11-17) ### Bug Fixes * CSSTidy ImportantComments not handled properly ([#359](#359)) ([78a9b4d](78a9b4d)) * fix CI ([#361](#361)) ([9ec687c](9ec687c)) * Invalid scheme check in Attr.TargetBlank ([#363](#363)) ([0176ef4](0176ef4)) * semantic release ([#339](#339)) ([d82f3d9](d82f3d9)) * semantic release ([#341](#341)) ([e55fead](e55fead)), closes [#339](#339) * Support for locales using decimal separators other than . (dot) ([#372](#372)) ([43f49ac](43f49ac)) ### Features * Add support for all text-decoration properties ([#360](#360)) ([2d775c0](2d775c0)) * Allows commas to be included in tel URI ([#389](#389)) ([ec92490](ec92490)), closes [#388](#388) ### Reverts * Revert "fix: semantic release (#339)" (#340) ([3e83215](3e83215)), closes [#339](#339) [#340](#340)
|
🎉 This PR is included in version 4.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using somtehing like
setlocale(LC_ALL, 'de_DE');the functionsprintf('%.1f, ...)'will use a comma for decimal separation. The functionis_numeric()will outputfalsefor strings containing a comma. Thereby I had to replace the decimal separator of the used locale with a dot.