Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): release 5.0.0 #73

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2022

🤖 I have created a release beep boop

5.0.0 (2022-03-12)

⚠ BREAKING CHANGES

  • Parsing of params in route paths now uses the path-to-regexp library which is what express.js uses also. Before this change there was no validation of passed path params while now the API call will fail if the params don't match what the route path expects.

Bug Fixes

  • ensure bundled version of path-to-regexp is used (#74) (2ee628b)
  • make params matching use express logic (#70) (6f520cd)

This PR was generated with Release Please. See documentation.

@rchl
Copy link
Collaborator

rchl commented Mar 8, 2022

I'd like to wait with this because the fix for #71 would also likely be a breaking change.

But at the same time, it would be nice to release this as a beta so that I could test it in real application.

I obviously can't release myself but if you could @ezypeeze , that would be nice.
I've created a beta branch for the beta release. Could you check it out and publish it using

npm publish --tag beta

?

@ezypeeze
Copy link
Owner

ezypeeze commented Mar 8, 2022

@rchl done! https://www.npmjs.com/package/nuxt-neo/v/5.0.0-beta.0

@github-actions github-actions bot force-pushed the release-please--branches--master branch from 4ca0474 to 4b109d6 Compare March 9, 2022 16:48
@rchl
Copy link
Collaborator

rchl commented Mar 12, 2022

I'm pretty happy with those changes now and would say that we could release it.

Just one thing to keep in mind... For optional parameters (/foo?), passing empty string will trigger an error when compiling the path. The library expects either a non-empty string or undefined in that case. It seems a bit inconvenient but probably makes sense from the lib's perspective.

rchl
rchl previously approved these changes Mar 12, 2022
@github-actions github-actions bot force-pushed the release-please--branches--master branch from 4b109d6 to 91416c2 Compare March 12, 2022 10:27
@rchl rchl merged commit 33742b8 into master Mar 14, 2022
@rchl rchl deleted the release-please--branches--master branch March 14, 2022 10:25
@github-actions
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants