Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Efficient implementation of frobenius_norm for all structures. #73

Merged
merged 15 commits into from
Jun 23, 2024

Conversation

f-dangel
Copy link
Owner

Only review after #70.

Resolves f-dangel/sirfshampoo#13.

@runame runame self-requested a review June 23, 2024 13:05
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runame runame merged commit 48dea18 into main Jun 23, 2024
14 checks passed
@runame runame deleted the efficient-frobenius-norm branch June 23, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] Implement StructuredMatrix.frobenius_norm efficiently
2 participants