-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added message for low funds #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
{% if showmemberbalance %} | ||
<br> | ||
<b> | ||
Tilbagestående beløb: {{newmemberbalance}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a hint that they should insert more money soon.
I don't think we should leave peoples balance visible, I think either there should be timeout after which the message disappear, or the message should only state that the account balance is below 5000, or both |
Agree. I would like to wait for #182 to be merged. |
I have updated the code to remove the remaning amount, using the same method as in #182 |
Co-authored-by: Falke Carlsen <falke.cs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
LGTM |
Feature branch needs to catch up with next. 170 commits behind |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## next #181 +/- ##
==========================================
+ Coverage 80.51% 80.53% +0.02%
==========================================
Files 32 32
Lines 2812 2816 +4
Branches 217 217
==========================================
+ Hits 2264 2268 +4
Misses 513 513
Partials 35 35
|
…ve and API, add blink to balance for eye-catching
@joandrsn made feature catch up and added blinking, note that only Chrome-based browsers load |
If you have under a balance under 5000, you should get a message, notifying you that you might soon be banned.