-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ranking feature to userinfo #256
Conversation
Codecov Report
@@ Coverage Diff @@
## next #256 +/- ##
==========================================
- Coverage 82.44% 81.37% -1.08%
==========================================
Files 30 30
Lines 2336 2378 +42
Branches 167 174 +7
==========================================
+ Hits 1926 1935 +9
- Misses 381 413 +32
- Partials 29 30 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Julian Teu <julian@jtle.dk>
Fixed in a2bb5e6 |
Users can click 'Rangliste' under userinfo to get their ranking in all categories:
For comparison, the SQL queries takes only ~150ms for sales during the last year.
Unfortunately this is slow as molasses, which could be alleviated by caching - but that's effort.
Currently this is all time, should probably also have a 'since Fjulefrokost' or possibly allow users to specify a timerange.
Closes #255
Suggestions and discussions from #163 and #177 should be considered for this PR
Edit: Now even more comprehensive: