Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bats/flakes from overlapping QR-codes #315

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

jonasKjellerup
Copy link
Contributor

Addresses issues #303.

  • Sets relative positioning and z-index of QR-codes on the user/pay page.
  • Tested for bats, beerflakes, and snowflakes.

@codecov-commenter
Copy link

Codecov Report

Merging #315 (2b015ff) into next (35d32f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #315   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          31       31           
  Lines        2659     2659           
  Branches      188      188           
=======================================
  Hits         2209     2209           
  Misses        418      418           
  Partials       32       32           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@VirtualSatai VirtualSatai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be more fun to always have a bat in the QR code, but it not fucking it up because of the redundancy allowed in QR codes. Anyway, this LGTM :shipit:

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@falkecarlsen falkecarlsen merged commit 1da8f9b into f-klubben:next Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants