Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero error in heatmap #393

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

krestenlaust
Copy link
Member

Forgot to handle the case of a user only buying products which cost 0 F$.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #393 (cfb82d0) into next (049016d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cfb82d0 differs from pull request most recent head 81f77f8. Consider uploading reports for the commit 81f77f8 to get more accurate results

@@           Coverage Diff           @@
##             next     #393   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          33       33           
  Lines        4544     4544           
  Branches      267      267           
=======================================
  Hits         2431     2431           
  Misses       2063     2063           
  Partials       50       50           
Files Coverage Δ
stregsystem/purchase_heatmap.py 57.28% <100.00%> (ø)

@krestenlaust krestenlaust merged commit 80314b0 into next Nov 9, 2023
@jones-g jones-g self-requested a review November 10, 2023 10:19
Copy link

@jones-g jones-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully endorse this product and/or service

@atjn atjn deleted the fix-division-by-zero-heatmap branch September 23, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants