Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added white links to the blue background #399

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

Murmeldyret
Copy link
Contributor

It is impossible to see the links on the blue background when it is christmas. This change will force all links to be white, when christmas time arrives.

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snow.css appears to be included at all times. We'll need to look into only including the change for this time of the year.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (537c5e5) 53.49% compared to head (64e2287) 53.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #399   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          33       33           
  Lines        4544     4544           
  Branches      267      267           
=======================================
  Hits         2431     2431           
  Misses       2063     2063           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍 thanks for coming up with the css needed!

Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works on my machine

only thing i don't like is how the text in the table under Brugerinfo's lowest row is the same color as the background.
Screenshot_20231204_174925

@krestenlaust
Copy link
Member

LGTM, works on my machine

only thing i don't like is how the text in the table under Brugerinfo's lowest row is the same color as the background. Screenshot_20231204_174925

I'm afraid that's another issue all together. The page should probably be extended further during the christmas theme 🤔

@krestenlaust
Copy link
Member

krestenlaust commented Dec 4, 2023

I've opened a new (aptly named) issue for that issue: #402

@krestenlaust krestenlaust merged commit a724c9d into f-klubben:next Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants