-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added white links to the blue background #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snow.css appears to be included at all times. We'll need to look into only including the change for this time of the year.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #399 +/- ##
=======================================
Coverage 53.49% 53.49%
=======================================
Files 33 33
Lines 4544 4544
Branches 267 267
=======================================
Hits 2431 2431
Misses 2063 2063
Partials 50 50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍 thanks for coming up with the css needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a new (aptly named) issue for that issue: #402 |
It is impossible to see the links on the blue background when it is christmas. This change will force all links to be white, when christmas time arrives.