Implement new Mobilepay reporting API #416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #416 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 33 33
Lines 4553 4553
Branches 267 267
=======================================
Hits 2434 2434
Misses 2069 2069
Partials 50 50 ☔ View full report in Codecov by Sentry. |
|
Stale until we get a response as to whether or not API-keys will be available to us |
I had accidentally included a header item in the payload, and passed a wrong value in payload. Furthermore, the authorization string is now encoded with base64
|
Notable difference: There's no transaction ID in the new API, so I'll be using PSP-reference as that seems like it's closest to it. It's only used for recognizing duplicates anyway |
The equivalent fields have been changed
Had to rewrite fetch_transactions to accumulate multiple calls
I've corrected query parameters and the handling of response
If someone where to accidentally run imports back into manual payments, then they'd be registered twice (I think)
I regret making the changes to a duplicate instead of simply changing the existing file
|
It has been tested in a local setup now, and it imported items successfully |
|
The prod tokens are located in my home folder on the server @falkecarlsen @BoAnd |
There was a problem hiding this comment.
LGTM with @BoAnd suggestions.
As you are aware, be careful with duplicate payments during deployment. You could deploy outside business-hours.
Co-authored-by: Falke Carlsen <11318702+falkecarlsen@users.noreply.github.com>
Resolves #407
New API endpoint: https://api.vipps.no/
Resources: