Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added next year to yearly report page #443

Merged

Conversation

MartinPTielemans
Copy link
Contributor

I added the next year button to the yearly report page. Next year will be hidden while the displayed year is the current year or more.

…ll be hidden while the displayed year is the current year or more.
@MartinPTielemans MartinPTielemans linked an issue May 1, 2024 that may be closed by this pull request
Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

stregsystem/templates/admin/stregsystem/report/ranks.html Outdated Show resolved Hide resolved
Co-authored-by: Kresten Laust <krestenlaust@gmail.com>
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.52%. Comparing base (af0efd8) to head (d158eb2).
Report is 4 commits behind head on next.

❗ Current head d158eb2 differs from pull request most recent head 17fb297. Consider uploading reports for the commit 17fb297 to get more accurate results

Files Patch % Lines
stregreport/views.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #443      +/-   ##
==========================================
- Coverage   53.45%   48.52%   -4.94%     
==========================================
  Files          33       33              
  Lines        4553     3856     -697     
  Branches      267      207      -60     
==========================================
- Hits         2434     1871     -563     
+ Misses       2069     1931     -138     
- Partials       50       54       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you merge whenever (squash merge only)

@MartinPTielemans MartinPTielemans merged commit bd2ba65 into next May 1, 2024
3 of 4 checks passed
@atjn atjn deleted the 406-no-next-year-button-on-yearly-report-page branch September 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No 'next year' button on yearly report page
2 participants