Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Year's Theme to themes.json and created required files #547

Open
wants to merge 16 commits into
base: next
Choose a base branch
from

Conversation

naeimehnajafi
Copy link

  • Added the New Year's theme configuration to themes.json.
  • Created newyear.html, newyear.css, and newyear.js files under the appropriate directory.
  • Verified file paths and updated JSON configuration.

@mads256h
Copy link
Member

mads256h commented Jan 8, 2025

We already have a new years theme. See the "fireworks" theme.

@JakobTopholt
Copy link
Contributor

@mads256h I think she knows, the issue related to this PR asks for a huge rocket on the moment of midnight.

@mads256h
Copy link
Member

mads256h commented Jan 13, 2025

@JakobTopholt I am just confused as to why a new theme is added

@krestenlaust
Copy link
Member

@JakobTopholt I am just confused as to why a new theme is added

With the new theme system, themes can easily overlap, so you could just overlap the news rocket theme with the existing theme.

But with that said, it's a little silly to not build on top of the existing new year's rocket code

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (a02bfdb) to head (62503e1).
Report is 8 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #547      +/-   ##
==========================================
+ Coverage   80.80%   80.88%   +0.07%     
==========================================
  Files          40       40              
  Lines        3809     3876      +67     
  Branches      481      487       +6     
==========================================
+ Hits         3078     3135      +57     
- Misses        675      684       +9     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix Liquid syntax error in themes.md
I replaced the `{% themes_static %}` tag in `themes.md` with a Jekyll-compatible tag. The error occurred on line 87, and this fix should resolve the Pages build issue.
@naeimehnajafi
Copy link
Author

Hi,

I have integrated the rocket effect into the existing "fireworks" theme as per your guidance. The updates include:

  • Adjustments in fireworks.css to incorporate the rocket visuals and animations.
  • Updated fireworks.html to include the rocket’s <div> and logic.
  • Verified and adjusted paths in themes.md and themes.json for consistency.
    Let me know any issues.
    Thank you for your help and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants