-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New Year's Theme to themes.json and created required files #547
base: next
Are you sure you want to change the base?
Conversation
We already have a new years theme. See the "fireworks" theme. |
@JakobTopholt I am just confused as to why a new theme is added |
With the new theme system, themes can easily overlap, so you could just overlap the news rocket theme with the existing theme. But with that said, it's a little silly to not build on top of the existing new year's rocket code |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #547 +/- ##
==========================================
+ Coverage 80.80% 80.88% +0.07%
==========================================
Files 40 40
Lines 3809 3876 +67
Branches 481 487 +6
==========================================
+ Hits 3078 3135 +57
- Misses 675 684 +9
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
Fix Liquid syntax error in themes.md
I replaced the `{% themes_static %}` tag in `themes.md` with a Jekyll-compatible tag. The error occurred on line 87, and this fix should resolve the Pages build issue.
Hi, I have integrated the rocket effect into the existing "fireworks" theme as per your guidance. The updates include:
|
newyear.html
,newyear.css
, andnewyear.js
files under the appropriate directory.