[WIP] 회원가입/로그인 리펙토링 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 24, 2024 10:39
회원가입시에만 사용가능한 enum을 공통으로 사용할 수 있도록 ApiResponse로 변경
클라이언트로 받은 요청을 객체로 리턴하도록 Dto 추가
/users 공통되어 @RequestMapping으로 통합
commonService에서 처리
명시적으로 표현하기위해 네이밍 변경 ApiRepsonse -> ApiResponseEnum
ApiResponseDto를 공통 결과 클래스 ApiResult로 변경
실패할 경우
{
"code": "EMPTY_EMAIL",
"message": "이메일이 비어있습니다",
"data": null
}
성공할 경우
{
"code": "SUCCESS",
"message": "요청에 성공하였습니다",
}
JsonInclude 추가. NON_NULL로 설정한 경우 빈 값도 들어갈 수 있기떄문에 NON_EMPTY로 설정
commonService -> CommonService
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[주요변경점]
{ "code": "EMPTY_PASSWORD", "message": "비밀번호가 비어있습니디" }