This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#42] Owner 단위테스트 작성 및 코드 리팩토링 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-dev
reviewed
Nov 29, 2019
| == null) { | ||
| log.error("id and password do not match id : {}, password : {}",id,beforePassword); | ||
| throw new IllegalArgumentException("id and password do not match"); | ||
| } else if (beforePassword.equals(afterPassword)) { |
There was a problem hiding this comment.
이런 경우는 beforePassword가 null일 경우 NPE가 발생합니다. StringUtils.equals를 사용하면 좋습니다.
f-lab-dev
approved these changes
Dec 3, 2019
yyy9942
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.