This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#67] 라이더 회원 정보 서비스 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yyy9942
commented
Jan 12, 2020
yyy9942
commented
- 회원 가입
- 로그인
- 로그아웃
- 아이디와 비밀번호로 유효성 검사
- 비밀번호 변경
- 메일 변경
- 회원 가입 - 로그인 - 로그아웃 - 아이디와 비밀번호로 유효성 검사 - 비밀번호 변경 - 메일 변경
f-lab-dev
reviewed
Jan 13, 2020
| * @param jp 조인포인트 | ||
| * @throws Throwable 발생 가능한 예외 설정 | ||
| */ | ||
| @Before("@annotation(com.delfood.aop.RiderLoginCheck)") |
There was a problem hiding this comment.
만약 @LoginCheck 어노테이션에 userLevel 같은 옵션을 하나 만들어두면 어노테이션을 하나만 사용할 수 있지 않을까요?
| * @param session 사용자의 세션 | ||
| * @param request 변경전 비밀번호, 변경할 비밀번호 정보 | ||
| */ | ||
| @PatchMapping("update/password") |
There was a problem hiding this comment.
update, create등 오퍼레이션의 내용은 URL에 들어있지 않는게 좋습니다~
| @@ -0,0 +1,7 @@ | |||
| package com.delfood.error.exception; | |||
|
|
|||
| public class IdDeletedException extends IllegalArgumentException { | |||
There was a problem hiding this comment.
이전에 사용했던 Exception중에 재활용할만한게 없을까요?
f-lab-dev
approved these changes
Jan 14, 2020
| ((ServletRequestAttributes) (RequestContextHolder.currentRequestAttributes())).getRequest() | ||
| .getSession(); | ||
|
|
||
| if (LoginCheck.UserType.MEMBER.equals(loginCheck.type())) { |
There was a problem hiding this comment.
switch-case문을 사용하면 더 깔끔할것 같네요~
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.