Add Msw account api #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
virere
reviewed
Jan 2, 2025
virere
reviewed
Jan 2, 2025
| const parsedHeader = String(header.get('Authorization') || ' ').split(' '); | ||
| try { | ||
| const result = await jwtDecrypt<JwtPayloadType>(parsedHeader[1], secret) | ||
| if (!result) throw new Error() |
There was a problem hiding this comment.
현재 설계상 parseAuth의 경우 이미 auth verification이 이루어진 다음 step에서 이루어지기 때문에 거의 무조건 반환되어야 하는 값입니다.
다만, 휴먼미싱이 우려되긴하네요... 추가하도록 하겠습니답.
There was a problem hiding this comment.
앗.. 따로 필요 없습니다. 왜냐면 현바로 그 아래에서 catch해서 오류메시지가 있는 ErrorException으로 대체하여 throw하기 때문입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 작업목록