This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
[#55] 외부에서 주입한 설정 값을 사용할 수 있도록 수정 #58
Open
cyj199637
wants to merge
14
commits into
develop
Choose a base branch
from
feature/55
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FirebaseConfig의 ClassPathResource()를 PathResource()로 수정
- firebase.account.key.path 수정
- FirebasePushService의 ClassPathResource()를 PathResource()로 수정
- PathResource()를 FileSystemResource()로 수정
- FileSystemResource()에서 FileInputStream()으로 수정
- FileSystemResource 로 수정
- ResourceUtils.getFile()로 수정
- FileInputStream()으로 수정
f-lab-dev
reviewed
Jan 25, 2021
firebase.account.key.path=C:\\Users\\cyj19\\Desktop\\Project\\sns-server\\src\\main\\resources\\sns-itda-firebase-adminsdk.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거는 application.properties
에 있기 때문에 모든 환경에 적용되는데 윈도우에 종속적인 값이 들어가고있네요~
Closed
- 로컬 환경에 종속적인 Properties 값을 application-deb.properties로 이동
[#59] 환경에 따른 Properties 분리
f-lab-dev
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.