[#15] 캔버스 내보내기, 불러오기 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-guell
reviewed
Jan 8, 2025
src/components/layout/Header.js
Outdated
| const buffer = await file.arrayBuffer(); | ||
| this.readFile(buffer); | ||
| } catch (error) { | ||
| console.error('파일 불러오기 실패:', error); |
There was a problem hiding this comment.
로그만 남기는 에러 핸들링은 무의미해보여요.
There was a problem hiding this comment.
현재 png 뿐만 아니라 bin 파일로 레이어 내보내기,레이어 불러오기도 구현했습니다!
멘토님 말씀대로 캔버스 레이어 list를 통해 json 값을 가져오고 bin 파일로 내보내기, 불러오기를 하고 있습니다.
처음엔 json 파일로 내보내기, 불러오기를 진행했는데 사용자가 파일을 열어 수정하는 것을 원치 않아서 수정 했습니다.
f-lab-guell
reviewed
Jan 9, 2025
| @@ -66,7 +104,7 @@ export default class CanvasArea extends HTMLElement { | |||
| render() { | |||
| this.innerHTML = ` | |||
| <div class="canvas-wrapper"> | |||
| <canvas id="drawingCanvas" width="${this.width}" height="${this.height}"></canvas> | |||
| <canvas id="drawingCanvas" ></canvas> | |||
There was a problem hiding this comment.
Suggested change
| <canvas id="drawingCanvas" ></canvas> | |
| <canvas id="drawingCanvas"></canvas> |
f-lab-guell
reviewed
Jan 9, 2025
Comment on lines
5
to
16
| connectedCallback() { | ||
| this.render(); | ||
| const buttonHandlers = { | ||
| 'download-button': this.handleDownload, | ||
| 'export-button': this.handleExport, | ||
| 'import-button': this.handleFileImport, | ||
| }; | ||
|
|
||
| Object.entries(buttonHandlers).forEach(([id, handler]) => { | ||
| this.querySelector(`#${id}`).addEventListener('click', handler); | ||
| }); | ||
| } |
There was a problem hiding this comment.
이렇게 보면 함수의 역할이 connectedCallback 이 아니라 init 같긴하네요...
f-lab-guell
reviewed
Jan 9, 2025
| this.currentProperty.opacity = Number(opacity); | ||
| this.currentProperty.opacity = opacity; | ||
| }); | ||
| eventBus.on('TEXT_CHANGED', ({ text }) => { |
There was a problem hiding this comment.
changed 보다는 update 같기도 하네요.ㅎㅎ
f-lab-guell
approved these changes
Jan 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue : #15
구현 기능