Fix different CFBundleName and CFBundleDisplayName on iOS info.plist #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix the case when users already manually change the default name of the app before.
How: Replaced
String bundleNamewithMap<String, String> bundleNames, that contains CFBundleName and CFBundleDisplayName if are exists, that will replace CFBundleName and CFBundleDisplayName in Info.plist for new bundle name also if they are not equals.Also added new test for that case and removed some unused code at
common.dart.P. S. It's my first public pull-request for open source, so thank you for a feedback :)