Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for unbinding just a single component's store events #34

Merged
merged 1 commit into from
Sep 28, 2014
Merged

Fix for unbinding just a single component's store events #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/delorean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,11 +442,15 @@
};
}

// Remember the change handlers so they can be removed later
this.__changeHandlers = {}

/* Generate and bind the change handlers to the stores. */
for (var storeName in this.stores) {
if (__hasOwn(this.stores, storeName)) {
store = this.stores[storeName];
store.onChange(__changeHandler(store, storeName));
this.__changeHandlers[storeName] = __changeHandler(store, storeName)
store.onChange(this.__changeHandlers[storeName]);
}
}
},
Expand All @@ -456,8 +460,7 @@
for (var storeName in this.stores) {
if (__hasOwn(this.stores, storeName)) {
var store = this.stores[storeName];
/* FIXME: What if another mounted view listening this store? Commenting out for now. */
store.listener.removeAllListeners('change');
store.listener.removeListener('change', this.__changeHandlers[storeName]);
}
}
},
Expand Down