Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency intl to >=0.17.0 <1.0.0 #11

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

zeshuaro
Copy link
Contributor

@zeshuaro zeshuaro commented Feb 14, 2023

Getting the following error when I try to bump intl to 0.18.0 in my project (PR for reference):

Because change 0.5.0 depends on intl ^0.17.0 and no versions of change match >0.5.0 <0.6.0, change ^0.5.0 requires intl ^0.17.0.
And because cider 0.1.3 depends on change ^0.5.0, cider 0.1.3 requires intl ^0.17.0.
So, because appainter depends on both intl 0.18.0 and cider 0.1.3, version solving failed.

From Pub docs and this related issue, they explain why Pub is unable to resolve intl to the latest version 0.18.0:

There is a notion of compatibility between pre-1.0.0 versions. Semver deems all pre-1.0.0 versions to be incompatible. This means that the only way to ensure compatibility when depending on a pre-1.0.0 package is to pin the dependency to an exact version. Pinned version constraints prevent automatic patch and pre-release updates. To avoid this situation, pub defines the "next breaking" version as the version which increments the major version if it's greater than zero, and the minor version otherwise, resets subsequent digits to zero, and strips any pre-release or build suffix. For example, here are some versions along with their next breaking ones:

0.0.3 -> 0.1.0 0.7.2-alpha -> 0.8.0 1.2.3 -> 2.0.0

To make use of this, pub defines a "^" operator which yields a version constraint greater than or equal to a given version, but less than its next breaking one.

It's probably safe to assume intl is not rolling out breaking changes until they release 1.0.0, as the recent release also doesn't contain any breaking changes. So this PR relaxes the constraints of intl to >=0.17.0 <1.0.0.

After releasing a new version of change, I think cider would also need to be updated to use the latest version of change to actually resolve the problem I reported at the top.

@f3ath f3ath merged commit c9eb652 into f3ath:master Feb 15, 2023
@f3ath
Copy link
Owner

f3ath commented Feb 15, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants