Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump and log have no subcommands #69

Closed
marvin-kolja opened this issue Jan 18, 2024 · 2 comments · Fixed by #70
Closed

bump and log have no subcommands #69

marvin-kolja opened this issue Jan 18, 2024 · 2 comments · Fixed by #70

Comments

@marvin-kolja
Copy link
Contributor

marvin-kolja commented Jan 18, 2024

Description

Currently, cider bump <part> and cider log <type> are not subcommands. Thus, something like cider bump --help doesn't print the correct information.

You can take a look at how the change looks like here: marvin-kolja@473acd1

Current Behaviour

$ dart bin/cider.dart bump --help
Bump project version

Usage: cider bump [arguments]
-h, --help               Print this usage information.
    --[no-]keep-build    Keep the existing build
    --[no-]bump-build    Also bump the build
    --build              Sets the build to the given value
                         (defaults to "")
    --pre                Sets the pre-release to the given value
                         (defaults to "")

Run "cider help" to see global options.

Wanted behaviour

$ dart bin/cider.dart bump --help
Bump project version

Usage: cider bump <subcommand> [arguments]
-h, --help    Print this usage information.

Available subcommands:
  breaking   Bump the breaking version
  build      Bump the build version
  major      Bump the major version
  minor      Bump the minor version
  patch      Bump the patch version
  pre        Bump the pre-release version
  release    Bump the release version

Run "cider help" to see global options.
$ dart bin/cider.dart bump breaking --help
Bump the breaking version

Usage: cider bump breaking [arguments]
-h, --help               Print this usage information.
    --[no-]keep-build    Keep the existing build
    --[no-]bump-build    Also bump the build
    --build              Sets the build to the given value
                         (defaults to "")
    --pre                Sets the pre-release to the given value
                         (defaults to "")

Run "cider help" to see global options.
@marvin-kolja marvin-kolja changed the title bump and log are not subcommands bump and log have no subcommands Jan 18, 2024
@f3ath
Copy link
Owner

f3ath commented Jan 28, 2024

Thank you. The change you're suggesting seems to be a nice UX improvement, wanna open a PR?

@marvin-kolja
Copy link
Contributor Author

Fantastic, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants