Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add!: proper sub commands for bump and log commands #70

Merged
merged 6 commits into from
Jan 31, 2024
Merged

add!: proper sub commands for bump and log commands #70

merged 6 commits into from
Jan 31, 2024

Conversation

marvin-kolja
Copy link
Contributor

Closes #69

f3ath
f3ath reviewed Jan 30, 2024
View reviewed changes
test/functional_test.dart Outdated Show resolved Hide resolved
f3ath
f3ath reviewed Jan 31, 2024
View reviewed changes
test/functional_test.dart Outdated Show resolved Hide resolved
f3ath
f3ath reviewed Jan 31, 2024
View reviewed changes
test/functional_test.dart Outdated Show resolved Hide resolved
@f3ath
Copy link
Owner

f3ath commented Jan 31, 2024

Great job. We're pretty close. Just a few nitpicking comments really.

@marvin-kolja marvin-kolja requested a review from f3ath January 31, 2024 01:49
@f3ath f3ath merged commit e1e59c7 into f3ath:master Jan 31, 2024
1 check passed
@f3ath
Copy link
Owner

f3ath commented Jan 31, 2024

Thank you!

@marvin-kolja marvin-kolja mentioned this pull request Jan 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f3ath f3ath Awaiting requested review from f3ath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump and log have no subcommands
2 participants
@marvin-kolja @f3ath