Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing wheel cache (seems broken) #128

Closed
wants to merge 1 commit into from
Closed

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Dec 11, 2023

No description provided.

@Meakk Meakk self-assigned this Dec 11, 2023
@mwestphal
Copy link
Contributor

why do you update the superbuild though ?

@Meakk
Copy link
Contributor Author

Meakk commented Dec 11, 2023

That's a mistake, thanks

@Meakk
Copy link
Contributor Author

Meakk commented Dec 11, 2023

@mwestphal see https://github.com/f3d-app/f3d-superbuild/actions/runs/7164851701/job/19505672622?pr=124#step:3:3635

My understanding is scikit build is automatically targeting 10.9 ( see https://scikit-build.readthedocs.io/en/latest/generators.html#default-deployment-target-and-architecture).
However, it's trying to link to the system library zstd built on 12.0.
So the questions are:

  • Why does netcdf have a dependency on zstd now?
  • Why is the cache is not rebuilding it? (should we add more things like deps versions in the cache key?)

@mwestphal
Copy link
Contributor

Why does netcdf have a dependency on zstd now?

Looks like optional dependency to zstd was added fairly recently in netcdf:
Unidata/netcdf-c#2173

But there is no zstd project in the superbuild, so it should be disabled instead of using system zstd.

Not sure what changed though, all of that is at least 6 month old or more.

Why is the cache is not rebuilding it?

There is no zstd project, so it cant be built.

should we add more things like deps versions in the cache key?

The wheels system require changing the cache number manually whenever we change anything that may require a rebuild of the superbuild. I'm open to improve that but it would require separating it in another repository imo.

@Meakk
Copy link
Contributor Author

Meakk commented Dec 11, 2023

But there is no zstd project in the superbuild, so it should be disabled instead of using system zstd.

Any idea how to disabled it?

@Meakk
Copy link
Contributor Author

Meakk commented Dec 11, 2023

@Meakk Meakk closed this Dec 11, 2023
@Meakk Meakk deleted the test-cache branch December 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants