Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D gaussians .splat reader #1248

Merged
merged 11 commits into from
Feb 8, 2024
Merged

3D gaussians .splat reader #1248

merged 11 commits into from
Feb 8, 2024

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Jan 31, 2024

No description provided.

@Meakk Meakk self-assigned this Jan 31, 2024
Meakk
Meakk commented Jan 31, 2024
View reviewed changes
plugins/native/CMakeLists.txt Outdated Show resolved Hide resolved
Meakk
Meakk commented Jan 31, 2024
View reviewed changes
Copy link
Contributor Author

@Meakk Meakk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[TODO] Add tests:
- Add a .splat file with an app test
- Create a simple bitonic sort test (generate random numbers, upload to the gpu, run bitonic sort shader, download the result, check if the buffer is ordered)

done

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (998a1b8) 96.51% compared to head (76104ee) 96.59%.
Report is 1 commits behind head on master.

Files Patch % Lines
...VTKExtensions/Rendering/vtkF3DPointSplatMapper.cxx 98.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
+ Coverage   96.51%   96.59%   +0.08%     
==========================================
  Files         131      138       +7     
  Lines        8208     8441     +233     
==========================================
+ Hits         7922     8154     +232     
- Misses        286      287       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor

needs a rebase

LucasGivord
LucasGivord reviewed Feb 3, 2024
View reviewed changes
application/F3DOptionsParser.cxx Show resolved Hide resolved
plugins/native/module/vtk.module Show resolved Hide resolved
plugins/native/module/vtkF3DSplatReader.h Outdated Show resolved Hide resolved
plugins/native/module/vtkF3DSplatReader.h Outdated Show resolved Hide resolved
library/src/options.cxx Show resolved Hide resolved
library/VTKExtensions/Rendering/glsl/vtkF3DBitonicSortFunctions.glsl Show resolved Hide resolved
mwestphal
mwestphal requested changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

.codespellrc Show resolved Hide resolved
library/VTKExtensions/Rendering/Testing/CMakeLists.txt Outdated Show resolved Hide resolved
library/VTKExtensions/Rendering/Testing/TestF3DBitonicSort.cxx Outdated Show resolved Hide resolved
library/VTKExtensions/Rendering/vtkF3DBitonicSort.cxx Show resolved Hide resolved
library/VTKExtensions/Rendering/vtkF3DBitonicSort.cxx Show resolved Hide resolved
plugins/native/CMakeLists.txt Show resolved Hide resolved
plugins/native/module/vtkF3DSplatReader.cxx Outdated Show resolved Hide resolved
plugins/native/module/vtkF3DSplatReader.cxx Outdated Show resolved Hide resolved
library/src/options.cxx Show resolved Hide resolved
plugins/native/CMakeLists.txt Show resolved Hide resolved
LucasGivord
LucasGivord reviewed Feb 4, 2024
View reviewed changes
Copy link

@LucasGivord LucasGivord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after finishing the article about the bitonic sort in compute shader, I can said that is good to me (even if I write few comments :) )

library/VTKExtensions/Rendering/glsl/vtkF3DBitonicSortFunctions.glsl Show resolved Hide resolved
library/VTKExtensions/Rendering/glsl/vtkF3DBitonicSortLocalSortCS.glsl Outdated Show resolved Hide resolved
library/VTKExtensions/Rendering/glsl/vtkF3DBitonicSortLocalDisperseCS.glsl Show resolved Hide resolved
@Meakk Meakk force-pushed the 3d-gaussian-final branch 2 times, most recently from bbc21db to 4c49832 Compare February 6, 2024 09:53
@Meakk
Copy link
Contributor Author

Meakk commented Feb 6, 2024

@mwestphal please take another look

mwestphal
mwestphal reviewed Feb 6, 2024
View reviewed changes
.lsan.supp Show resolved Hide resolved
mwestphal
mwestphal requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

@mwestphal
Copy link
Contributor

Gallery update maybe ?

@Meakk Meakk merged commit ef70bfa into f3d-app:master Feb 8, 2024
39 checks passed
@Meakk Meakk deleted the 3d-gaussian-final branch February 8, 2024 15:08
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
@Meakk
3D gaussians .splat reader (#1248)
9cc6ed9
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
3D gaussians .splat reader (f3d-app#1248)
7a3bdde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasGivord LucasGivord LucasGivord left review comments

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meakk @mwestphal @LucasGivord