-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add javascript to insert download buttons #1266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a screenshot in description ? :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 131 131
Lines 8202 8208 +6
=======================================
+ Hits 7916 7922 +6
Misses 286 286 ☔ View full report in Codecov by Sentry. |
mwestphal
reviewed
Feb 5, 2024
mwestphal
reviewed
Feb 5, 2024
mwestphal
approved these changes
Feb 6, 2024
Meakk
approved these changes
Feb 6, 2024
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
* add javrscript to insert download buttons * improve release table * fix script * fix script take 2 * fix script take 3 * style
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
* add javrscript to insert download buttons * improve release table * fix script * fix script take 2 * fix script take 3 * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to have big "get F3D button" for the current OS above the release table:
Include a script in the header, the script is loaded on every page but will perform different actions depending on which page it's in.
The idea is that the javascript only enhances the existing html, while being totally optional. We don't want to start adding <script> tags in the markdown documents.
In the case of the install page, the script retrieves the download links from the table in the page (html generated from the markdown file) and adds buttons for the ones where the "Platform" column matches the guessed client OS
edit: temporarily deployed at https://snoyer.github.io/f3d/doc/user/INSTALLATION.html
![screenshot](https://private-user-images.githubusercontent.com/489715/302340724-4ab689c0-b425-4970-99d7-3ccf04dcb78a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDA1ODUsIm5iZiI6MTczOTU0MDI4NSwicGF0aCI6Ii80ODk3MTUvMzAyMzQwNzI0LTRhYjY4OWMwLWI0MjUtNDk3MC05OWQ3LTNjY2YwNGRjYjc4YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMzM4MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNjRiZjQ4NTQxZjhhYjkyMjg1NjQxY2E4Y2MwMDFmYTc0ZTA0OWEyOWM1MzkxMGM5NzIwYmMyYjVjM2FjZDhkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jTA8WfPH4v1qbRwiOElDqrqJ04_kUHo43cdWw_oT9xM)
should look something like: