Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add javascript to insert download buttons #1266

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Feb 5, 2024

in order to have big "get F3D button" for the current OS above the release table:

Include a script in the header, the script is loaded on every page but will perform different actions depending on which page it's in.
The idea is that the javascript only enhances the existing html, while being totally optional. We don't want to start adding <script> tags in the markdown documents.

In the case of the install page, the script retrieves the download links from the table in the page (html generated from the markdown file) and adds buttons for the ones where the "Platform" column matches the guessed client OS

edit: temporarily deployed at https://snoyer.github.io/f3d/doc/user/INSTALLATION.html
should look something like:
screenshot

@mwestphal
Copy link
Contributor

add a screenshot in description ? :)

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b02ce73) 96.51% compared to head (2f8f792) 96.51%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files         131      131           
  Lines        8202     8208    +6     
=======================================
+ Hits         7916     7922    +6     
  Misses        286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal merged commit 8730300 into f3d-app:master Feb 6, 2024
39 checks passed
@snoyer snoyer deleted the website-download-buttons branch February 6, 2024 15:13
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
* add javrscript to insert download buttons

* improve release table

* fix script

* fix script take 2

* fix script take 3

* style
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
* add javrscript to insert download buttons

* improve release table

* fix script

* fix script take 2

* fix script take 3

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants