-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve quickstart guide #1563
base: master
Are you sure you want to change the base?
Improve quickstart guide #1563
Conversation
Thanks for your contribution @stepperpig ! Ill review thourougly when I can :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, a few changes needed and some precision asked.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1563 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 108 108
Lines 7671 7671
=======================================
Hits 7429 7429
Misses 242 242 ☔ View full report in Codecov by Sentry. |
removed .DS_Store file
shortened README qs
2e8a071
to
ca64d79
Compare
You still around @stepperpig ? This one is close to be merged :) |
sounds good! |
What I mean is that its still need a bit of work if you are up for it :) |
Fixes issue #1259
Changes:
Potential Suggestions: