-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with VTK and glad #1631
Conversation
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
+ Coverage 96.90% 97.01% +0.10%
==========================================
Files 104 105 +1
Lines 7830 7935 +105
==========================================
+ Hits 7588 7698 +110
+ Misses 242 237 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the regexp + baselines tests
Fix compatibility with VTK master and the upcoming VTK 9.4 release.
VTK now uses
glad
instead ofglew
, making it possible to select GLX, EGL or OSMesa at runtime instead of building a specific backend.Refactor the engine creation to use a factory in order to clarify which OpenGL context to use.