Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename loader into scene #1660

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Oct 8, 2024

Fix: #1656

Copy link

github-actions bot commented Oct 8, 2024

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@mwestphal mwestphal changed the title Remove loader into scene Rename loader into scene Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (1eeaf2c) to head (a46355b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1660   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         106      106           
  Lines        7836     7836           
=======================================
  Hits         7594     7594           
  Misses        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal requested a review from Meakk October 8, 2024 18:02
@mwestphal mwestphal merged commit 33771c5 into f3d-app:master Oct 8, 2024
40 checks passed
Yogesh9000 pushed a commit to Yogesh9000/f3d that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename loader into scene
2 participants