-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move coloring info logic into a dedicated handler #1672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwestphal
commented
Oct 22, 2024
•
edited
Loading
edited
- Move ColoringInfo logic out of vtkF3DMetaImporter and vtkF3DRenderer into a dedicated F3DColoringInfoHandler
- F3DColoringInfoHandler contains ColoringInfo maps as well as current coloring state
- F3DColoringInfoHandler is owned by the meta importer and accessed by the renderer
- Change the API in vtkF3DRenderer
- vtkF3DRenderer now handles arrayName and EnableColoring as standard properties
- Inform user when coloring is forced
- Fix small issues in vtkF3DRenderer with log and coverage
- Add/Update tests
- Update docs
- Fix Volume Rendering require coloring array to be set to work correctly #1651
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
- Coverage 97.01% 96.95% -0.06%
==========================================
Files 105 106 +1
Lines 7935 8612 +677
==========================================
+ Hits 7698 8350 +652
- Misses 237 262 +25 ☔ View full report in Codecov by Sentry. |
mwestphal
changed the title
[DRAFT] Move coloring info logic into a dedicated helper
Move coloring info logic into a dedicated handler
Oct 26, 2024
mwestphal
force-pushed
the
coloring_info_helper
branch
from
October 26, 2024 18:24
731f110
to
16e871b
Compare
snoyer
reviewed
Oct 27, 2024
snoyer
reviewed
Oct 27, 2024
snoyer
reviewed
Oct 27, 2024
snoyer
reviewed
Oct 27, 2024
snoyer
reviewed
Oct 27, 2024
Co-authored-by: snoyer <noyer.stephane@gmail.com>
Meakk
reviewed
Oct 28, 2024
Meakk
approved these changes
Oct 28, 2024
Yogesh9000
pushed a commit
to Yogesh9000/f3d
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.