Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coloring info logic into a dedicated handler #1672

Merged
merged 26 commits into from
Oct 28, 2024

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Oct 22, 2024

  • Move ColoringInfo logic out of vtkF3DMetaImporter and vtkF3DRenderer into a dedicated F3DColoringInfoHandler
  • F3DColoringInfoHandler contains ColoringInfo maps as well as current coloring state
  • F3DColoringInfoHandler is owned by the meta importer and accessed by the renderer
  • Change the API in vtkF3DRenderer
  • vtkF3DRenderer now handles arrayName and EnableColoring as standard properties
  • Inform user when coloring is forced
  • Fix small issues in vtkF3DRenderer with log and coverage
  • Add/Update tests
  • Update docs
  • Fix Volume Rendering require coloring array to be set to work correctly #1651

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (e4cf9fe) to head (4cd6b3b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
- Coverage   97.01%   96.95%   -0.06%     
==========================================
  Files         105      106       +1     
  Lines        7935     8612     +677     
==========================================
+ Hits         7698     8350     +652     
- Misses        237      262      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal mwestphal requested a review from Meakk October 25, 2024 20:34
@mwestphal mwestphal changed the title [DRAFT] Move coloring info logic into a dedicated helper Move coloring info logic into a dedicated handler Oct 26, 2024
@mwestphal mwestphal force-pushed the coloring_info_helper branch from 731f110 to 16e871b Compare October 26, 2024 18:24
Co-authored-by: snoyer <noyer.stephane@gmail.com>
@mwestphal mwestphal requested a review from snoyer October 27, 2024 17:55
vtkext/private/module/F3DColoringInfoHandler.cxx Outdated Show resolved Hide resolved
vtkext/private/module/F3DColoringInfoHandler.cxx Outdated Show resolved Hide resolved
vtkext/private/module/vtkF3DRenderer.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested a review from Meakk October 28, 2024 16:25
@mwestphal mwestphal merged commit af79668 into f3d-app:master Oct 28, 2024
39 checks passed
Yogesh9000 pushed a commit to Yogesh9000/f3d that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume Rendering require coloring array to be set to work correctly
3 participants