Testing: Fix an issue with SDK image testing

library/public/image.h

@@ -144,6 +144,7 @@ class F3D_EXPORT image
    * Please note, due to possible arithmetic imprecision in the SSIM computation
    * using a threshold of zero may return false with identical images.
    * Depending on the VTK version, another comparison algorithm may be used.
+   * Threshold should be in range [0, 1[, this returns false otherwise.
    * 1e-14: Pixel perfect comparison.
    * 0.05: Visually indistinguishable.
    * 0.1: Small visible difference.

library/src/image.cxx

@@ -338,6 +338,13 @@ void* image::getContent() const
 //----------------------------------------------------------------------------
 bool image::compare(const image& reference, double threshold, double& error) const
 {
+  // Sanity check for threshold
+  if (threshold < 0 || threshold >= 1)
+  {
+    error = 1;
+    return false;
+  }
+
   ChannelType type = this->getChannelType();
   if (type != reference.getChannelType())
   {

library/testing/TestSDKCompareWithFile.cxx

@@ -14,7 +14,7 @@ int TestSDKCompareWithFile(int argc, char* argv[])
   sce.add(std::string(argv[1]) + "/data/cow.vtp");
 
   return TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-           std::string(argv[2]), "TestSDKCompareWithFile", 50)
+           std::string(argv[2]), "TestSDKCompareWithFile")
     ? EXIT_SUCCESS
     : EXIT_FAILURE;
 }

library/testing/TestSDKDropZone.cxx

@@ -16,7 +16,7 @@ int TestSDKDropZone(int argc, char* argv[])
   win.render();
 
   return TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-           std::string(argv[2]), "TestSDKDropZone", 50)
+           std::string(argv[2]), "TestSDKDropZone")
     ? EXIT_SUCCESS
     : EXIT_FAILURE;
 }

library/testing/TestSDKDynamicBackgroundColor.cxx

@@ -23,7 +23,7 @@ int TestSDKDynamicBackgroundColor(int argc, char* argv[])
   opt.render.background.color = { 1.0, 1.0, 1.0 };
 
   return TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-           std::string(argv[2]), "TestSDKDynamicBackgrounColor", 50)
+           std::string(argv[2]), "TestSDKDynamicBackgrounColor")
     ? EXIT_SUCCESS
     : EXIT_FAILURE;
 }

library/testing/TestSDKDynamicFontFile.cxx

@@ -23,7 +23,7 @@ int TestSDKDynamicFontFile(int argc, char* argv[])
   opt.ui.font_file = std::string(argv[1]) + "data/Crosterian.ttf";
 
   return TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-           std::string(argv[2]), "TestSDKDynamicFontFile", 50)
+           std::string(argv[2]), "TestSDKDynamicFontFile")
     ? EXIT_SUCCESS
     : EXIT_FAILURE;
 }

library/testing/TestSDKDynamicHDRI.cxx

@@ -42,7 +42,7 @@ int TestSDKDynamicHDRI(int argc, char* argv[])
   opt.render.hdri.ambient = true;
   opt.render.background.skybox = true;
   ret = TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-    std::string(argv[2]), "TestSDKDynamicHDRIDefault", 120);
+    std::string(argv[2]), "TestSDKDynamicHDRIDefault");
   if (!ret)
   {
     std::cerr << "Render with Default HDRI failed" << std::endl;
@@ -52,7 +52,7 @@ int TestSDKDynamicHDRI(int argc, char* argv[])
   // Change the hdri and make sure it is taken into account
   opt.render.hdri.file = std::string(argv[1]) + "data/palermo_park_1k.hdr";
   ret = TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-    std::string(argv[2]), "TestSDKDynamicHDRI", 50);
+    std::string(argv[2]), "TestSDKDynamicHDRI");
   if (!ret)
   {
     std::cerr << "Render with HDRI failed" << std::endl;
@@ -70,7 +70,7 @@ int TestSDKDynamicHDRI(int argc, char* argv[])
   // Force a cache path change to force a LUT reconfiguration and test dynamic cache path
   eng.setCachePath(std::string(argv[2]) + "/cache_" + std::to_string(dist(e1)));
   ret = TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-    std::string(argv[2]), "TestSDKDynamicHDRI", 50);
+    std::string(argv[2]), "TestSDKDynamicHDRI");
   if (!ret)
   {
     std::cerr << "Render with HDRI with another cache path failed" << std::endl;
@@ -80,7 +80,7 @@ int TestSDKDynamicHDRI(int argc, char* argv[])
   // Use an existing cache
   eng.setCachePath(cachePath);
   ret = TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-    std::string(argv[2]), "TestSDKDynamicHDRI", 50);
+    std::string(argv[2]), "TestSDKDynamicHDRI");
   if (!ret)
   {
     std::cerr << "Render with HDRI with existing cache path failed" << std::endl;
@@ -91,7 +91,7 @@ int TestSDKDynamicHDRI(int argc, char* argv[])
   // Change the hdri and make sure it is taken into account
   opt.render.hdri.file = std::string(argv[1]) + "/data/kloofendal_43d_clear_1k.exr";
   ret = TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-    std::string(argv[2]), "TestSDKDynamicHDRIExr", 50);
+    std::string(argv[2]), "TestSDKDynamicHDRIExr");
 
   if (!ret)
   {

library/testing/TestSDKDynamicLightIntensity.cxx

@@ -19,7 +19,7 @@ int TestSDKDynamicLightIntensity(int argc, char* argv[])
 
   // Check render with default light intensity
   if (!TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-        std::string(argv[2]), "TestSDKDynamicLightIntensity-default", 50))
+        std::string(argv[2]), "TestSDKDynamicLightIntensity-default"))
   {
     std::cerr << "failed for default light intensity" << std::endl;
     return EXIT_FAILURE;
@@ -28,7 +28,7 @@ int TestSDKDynamicLightIntensity(int argc, char* argv[])
   // set light intensity to 5x brighter
   opt.render.light.intensity = 5.;
   if (!TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-        std::string(argv[2]), "TestSDKDynamicLightIntensity-5x-brighter", 50))
+        std::string(argv[2]), "TestSDKDynamicLightIntensity-5x-brighter"))
   {
     std::cerr << "failed for light intensity = 5" << std::endl;
     return EXIT_FAILURE;
@@ -37,7 +37,7 @@ int TestSDKDynamicLightIntensity(int argc, char* argv[])
   // set light intensity to 5x darker
   opt.render.light.intensity = .2;
   if (!TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-        std::string(argv[2]), "TestSDKDynamicLightIntensity-5x-darker", 50))
+        std::string(argv[2]), "TestSDKDynamicLightIntensity-5x-darker"))
   {
     std::cerr << "failed for light intensity = .2" << std::endl;
     return EXIT_FAILURE;

library/testing/TestSDKDynamicProperties.cxx

@@ -26,7 +26,7 @@ int TestSDKDynamicProperties(int argc, char* argv[])
   opt.model.color.opacity = 0.6;
 
   return TestSDKHelpers::RenderTest(eng.getWindow(), std::string(argv[1]) + "baselines/",
-           std::string(argv[2]), "TestSDKDynamicProperties", 50)
+           std::string(argv[2]), "TestSDKDynamicProperties")
     ? EXIT_SUCCESS
     : EXIT_FAILURE;
 }

library/testing/TestSDKHelpers.h

@@ -54,7 +54,7 @@ static bool RenderTest(const f3d::image& img, const std::string& baselinePath,
 }
 
 static bool RenderTest(f3d::window& win, const std::string& baselinePath,
-  const std::string& outputPath, const std::string& name, double threshold = 50,
+  const std::string& outputPath, const std::string& name, double threshold = 0.05,
   bool noBackground = false)
 {
   return TestSDKHelpers::RenderTest(