Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude TIFF from thumbnailers #770

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Apr 25, 2023

Not validated on Windows thumbnailer yet

@Meakk Meakk self-assigned this Apr 25, 2023
@Meakk Meakk requested a review from mwestphal April 25, 2023 13:34
@mwestphal
Copy link
Contributor

should be documented somewhere in doc/user/

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doc about the fact that tif is not generating thumbnails

doc/user/USAGE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the tiff part from the thumbnail conf

@mwestphal
Copy link
Contributor

A test needs to be updated

@mwestphal
Copy link
Contributor

Approved but you cant merge until #784 is merged

@Meakk Meakk merged commit f7e5012 into f3d-app:master May 6, 2023
@Meakk Meakk deleted the exclude_thumb branch May 6, 2023 08:48
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants